Conversation
Added MvvmLight project for navigation including an MvvmPage and a base view model for handling navigation events. Updated samples to test functionality and added bug fixes to the Android navigation frame to be in line with UWP navigation.
tom-made
approved these changes
May 22, 2018
Contributor
tom-made
left a comment
tom-made
left a comment
There was a problem hiding this comment.
Happy with the changes here. Won't close off issue until support for iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Title
Added a new project for MvvmLight components for navigation. Includes a basic page which passes the navigation events off to a common backing view-model.
Also includes bug fixes for an issue with the navigation argument passed to the pages when navigating and navigated from. This is now inline with Windows functionality where it will pass the argument for the page that you're navigating to when navigating from and navigated from.
Associated Issues
#31 - [Feature] MvvmLight support for navigation